Create new SubProject to not depend on Dataflow in Kafka - #35452
Conversation
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
| name: PreCommit Java Kafka IO Dataflow | ||
|
|
||
| on: | ||
| push: |
There was a problem hiding this comment.
We can remove push trigger. It's not quite useful in practice
| pull_request_target: | ||
| branches: ['master', 'release-*'] | ||
| paths: | ||
| - "sdks/java/io/kafka/**" |
There was a problem hiding this comment.
Set to sdks/java/io/kafka/gmk-tests for now so it won't report failures on unrelated PR
|
waiting on author |
|
hey @fozzie15, is this PR still relevant? |
|
is this PR still relevant? |
|
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions. |
|
This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time. |
5 participants
These changes will add a new sub-project for kafka tests which depend on Dataflow. This will allow us to test changes on Dataflow without creating a circular dependency between Dataflow and Kafka. This test is required for the Managed Schema Transform Providers which have functionality when executed on Dataflow.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.